Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Docs: Update sample author name and email #8011

Closed
wants to merge 4 commits into from

Conversation

brainwane
Copy link
Contributor

Per https://groups.google.com/d/msg/pypa-dev/rUNsfIbruHM/LCEx-CB5AgAJ
the pypa-dev Google Group is now decommissioned.
Using this opportunity to, as in
pypa/sampleproject#118, improve the example author
name and email address.

Signed-off-by: Sumana Harihareswara sh@changeset.nyc

@di
Copy link
Member

di commented May 28, 2020

Since this is an example of an actual API response, we should probably make a new release of sampleproject and then update this to be what PyPI would actually return instead.

@brainwane
Copy link
Contributor Author

That sounds fair.

@brainwane brainwane changed the title Docs: Update sample author name and email WIP Docs: Update sample author name and email May 28, 2020
@di di added the blocked Issues we can't or shouldn't get to yet label May 29, 2020
@di
Copy link
Member

di commented Jun 25, 2020

A new release of sampleproject has been made: https://pypi.org/project/sampleproject/2.0.0/

@brainwane brainwane changed the title WIP Docs: Update sample author name and email Docs: Update sample author name and email Jun 25, 2020
@brainwane brainwane changed the title Docs: Update sample author name and email WIP: Docs: Update sample author name and email Jun 25, 2020
@brainwane brainwane marked this pull request as draft June 25, 2020 22:41
@brainwane brainwane added APIs/feeds documentation and removed blocked Issues we can't or shouldn't get to yet labels Jun 25, 2020
Per https://groups.google.com/d/msg/pypa-dev/rUNsfIbruHM/LCEx-CB5AgAJ
the pypa-dev Google Group is now decommissioned.
Using this opportunity to, as in
pypa/sampleproject#118, improve the example author
name and email address.

Signed-off-by: Sumana Harihareswara <sh@changeset.nyc>
@brainwane brainwane marked this pull request as ready for review June 26, 2020 15:50
@brainwane brainwane marked this pull request as draft June 26, 2020 15:50
Base automatically changed from master to main January 21, 2021 18:39
miketheman added a commit to miketheman/warehouse that referenced this pull request Dec 18, 2022
As the API has evolved over time, update the example in the docs to
reflect current keys.

Closes pypi#8011

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@di di closed this in #12692 Dec 19, 2022
di pushed a commit that referenced this pull request Dec 19, 2022
* docs: update JSON API response with current shape

As the API has evolved over time, update the example in the docs to
reflect current keys.

Closes #8011

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

* lint: make the payload valid json

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants