Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url in welcome template. #123

Closed
wants to merge 55 commits into from
Closed

Conversation

michaelkuty
Copy link

fixed urls in links

<html><head><title>Welcome to pypiserver!</title></head><body>
<h1>Welcome to pypiserver!</h1>
<p>This is a PyPI compatible package index serving 86 packages.</p>

<p> To use this server with pip, run the the following command:
<blockquote><pre>
pip install -i http://10.10.10.122:9000/unstable/simple/ PACKAGE [PACKAGE2...]
</pre></blockquote></p>

<p> To use this server with easy_install, run the the following command:
<blockquote><pre>
easy_install -i http://10.10.10.122:9000/unstable/simple/ PACKAGE
</pre></blockquote></p>

<p>The complete list of all packages can be found <a href="packages/">here</a> or via the <a href="simple/">simple</a> index.</p>

<p>This instance is running version 1.0.0 of the <a href="http://pypi.python.org/pypi/pypiserver">pypiserver</a> software.</p>
</body></html>

@mplanchard
Copy link
Contributor

Hello, and thanks for contributing to pypiserver. Could you please expound a bit on the system on which you're seeing this bug? The changed link functionality works fine on my setup, and generates functional URLs that link to the package lists. In particular, could you make sure that you're seeing the same problem on the most recent version of pypiserver?

I've pasted the generated HTML from my pypiserver below (note that the URL has been redacted to prevent any sort of automated link crawlers from grabbing it).

<html><head><title>Welcome to pypiserver!</title></head><body>
<h1>Welcome to pypiserver!</h1>
<p>This is a PyPI compatible package index serving 71 packages.</p>

<p> To use this server with pip, run the the following command:
<blockquote><pre>
pip install --extra-index-url "pypiserver url" PACKAGE [PACKAGE2...]
</pre></blockquote></p>

<p> To use this server with easy_install, run the the following command:
<blockquote><pre>
easy_install -i "pypiserver url" PACKAGE
</pre></blockquote></p>

<p>The complete list of all packages can be found <a href="/packages/">here</a>
or via the <a href="/simple/">simple</a> index.</p>

<p>This instance is running version 1.1.10 of the
  <a href="http://pypi.python.org/pypi/pypiserver">pypiserver</a> software.</p>
</body></html>

@michaelkuty
Copy link
Author

Problem is with paste.ini

http://pypi.robotice.org/
http://pypi.robotice.org/unstable

on second link are wrong urls in links but in pip install command is ok because uses url instead of new path..

correct links are http://pypi.robotice.org/unstable/simple/

@mplanchard
Copy link
Contributor

Ah, I see. I will try to look into this in more depth when I find some time, but the proposed fix causes several tests to fail. We may need to either adjust the fix or adjust the tests to reflect the changes. Are you able to spend some time working on that?

@ankostis
Copy link
Member

@michaelkuty can you rebase on master?
#141 fixes the CI failure.

Also can you check without your fix if paste now works OK due to the redirection fix(#140)?

@mplanchard
Copy link
Contributor

Looks like all tests are still failing even with #141 being fixed. Please update with the status of the bug now that #140 is merged when you have time, @michaelkuty.

ankostis and others added 22 commits June 27, 2016 21:13
- Obviously a TC is needed there.
Fix typo, the package name in pypi is pypiserver and not pypi-server.
Fix typo, the package name is pypiserver
Update docs about `root=...` kwd when starting pypiserver via apache/mod_wsgi
…My result appears different than the expected outcome.
test_upload_with_signature fix to allow uploaded files in any order.
upload test requires pypirc to avoid password prompt
FIX pypiserver#124: Convert forgotten attr-access-->dict-access & TCs for paste-factory
PEP 503 Package Name Normalization and URL Redirects
- It's harder to make the listdir cache not recalculate, because when a file changes you need to only touch the file that changed. However, for file digests, the key is one-to-one, and very simple to invalidate.
- This cache is especially useful when you have a lot of really large packages
…te_directory = None, syntax result in a tuple but None and this code poison update in manage.py
i- Octapus commit just to close branches;
- actuall commits have been rebased.
* PEP 008 changes to __init__.py
* Updated CHANGES to reflect search addition by @blade2005
Craig Davis and others added 24 commits June 27, 2016 21:13
- Maintain separation of *pypiserver* project/service from ``pypi-server`` cmd.
- Add links to various projects mentioned.
- Delete `pip search` from "nown Limitations".
…d README to note that when using pam you need to install pam module
Added a try/except for importing pam with logging an error and update…
+ doc: Reformat changes.
@mplanchard
Copy link
Contributor

@ankostis I vote that we close this PR, as we have neither been able to replicate and have not had a response on the current status in some time.

@mplanchard
Copy link
Contributor

Closing due to lack of response. Feel free to re-open with new information or responses to questions.

@mplanchard mplanchard closed this Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants