Skip to content

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented Mar 31, 2021

@snowman2
Copy link
Member Author

Seems like Windows doesn't like the current implementation. Works on linux 🤷‍♂️

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #810 (bfb43d0) into master (ee5b86f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #810   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          21       21           
  Lines        1647     1649    +2     
=======================================
+ Hits         1567     1569    +2     
  Misses         80       80           
Impacted Files Coverage Δ
pyproj/transformer.py 95.87% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5b86f...bfb43d0. Read the comment docs.

@snowman2 snowman2 marked this pull request as ready for review April 1, 2021 00:34
@snowman2
Copy link
Member Author

snowman2 commented Apr 1, 2021

There are some edge cases mentioned here: OSGeo/PROJ#2616. But, I think this is a good enough start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant