add filter for boolean values in dict2string so "no_rot=True" works (issue #183)

[jswhit]

No description provided.

[snowman2]

@jswhit, I think not including the option if false would be better.

[snowman2]

Also, what about if they use None for the value?

[jswhit]

handles False and None now (None is treated like False, is that correct?)

[snowman2]

I was thinking None could be considered analagous to True as the None would be considered the same as not having a value for the argument. Thoughts on this logic?

...
if value is None or value is True:
    pjargs.append("+" + key + " ")
elif value is False:
    pass
...

[snowman2]

Just updated the code ^^

[jswhit]

Or None might be interpreted as don't have a no_rot flag added to the string....

[snowman2]

It seems cartopy interprets None as not having a value.
See: https://github.com/SciTools/cartopy/blob/45d0479abed27f73c5bb8bac35036772a3faa773/lib/cartopy/_crs.pyx#L177

[jswhit]

OK, changed it to your suggestion

[snowman2]

Sounds good, thanks for fixing this 👍

[TAlonglong]

Thank you for this quick respond to my issue.