Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Added pyproj.transformer.Transform.__eq__() #559

Merged
merged 1 commit into from
Mar 3, 2020
Merged

ENH: Added pyproj.transformer.Transform.__eq__() #559

merged 1 commit into from
Mar 3, 2020

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented Mar 3, 2020

  • Tests added
  • Fully documented, including history.rst for all changes and api/*.rst for new API

@snowman2 snowman2 merged commit f082fd3 into pyproj4:master Mar 3, 2020
jorisvandenbossche
jorisvandenbossche reviewed Mar 3, 2020
View reviewed changes
test/test_transformer.py


def test_transformer_not_equals():
assert Transformer.from_crs(28356, 7856) != 22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably also test with a non-equal Transformer object?

Copy link
Member Author

@snowman2 snowman2 Mar 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea 👍. If you have a free moment to submit a PR, that would be helpful, but not required.

@snowman2 snowman2 mentioned this pull request Mar 13, 2020
Merged
@snowman2 snowman2 deleted the transform_methods branch March 18, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snowman2 @jorisvandenbossche