Why do partition and timestamp default to 0 and 11 in producer record?

[fmjrey]

See

kinsky/src/kinsky/client.clj

Line 569 in a530907

(.send producer (->record {:key k :value v :topic topic :headers headers :partition 0 :timestamp 11})))

Timestamp defaulting to 11 and not 0 as specified by docstring seems weird.
More importantly, why do we need such defaults? They override Kafka API behavior with regards to default values, and they make (send! [this topic k v]) and (send! [this topic k v headers]) behave inconsistently (the first does not override Kafka API behavior, the second does).

Best is to not define any default values and let library clients handle them when needed.

[pyr]

Hi @fmjrey ,

Happy new year and thanks for the report!

[fmjrey]

Hi @pyr, best wishes to you too!
Thanks for correcting this, I had little time when I filed this issue and could have provided a PR.
Nevertheless I just submitted a larger PR that also completes your fix by removing the no longer necessary associated comment:
bd07134#diff-5b6773780a4aa4b34911da7bc0b98b21L570