Naive implementation of an url_for helper #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yohanboniface
force-pushed
the
url_for
branch
2 times, most recently
from
3a63e33
to
3607213
Compare
davidbgk
reviewed
Jun 10, 2020
yohanboniface
commented
Jun 13, 2020
davidbgk
reviewed
Jun 13, 2020
davidbgk
approved these changes
Jun 14, 2020
|
Thanks @yohanboniface ! |
|
@indatwood we are currently working on a fix, this is not recommended to switch to |
|
okay no worries, I'm in no hurry :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #119
(Sorry for Black noise, I ran it by instinct :( I can revert it if needed.)