Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge new api changes to xadd #135

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Merge new api changes to xadd #135

merged 2 commits into from
Dec 19, 2022

Conversation

mike-gimelfarb
Copy link
Collaborator

  • visualize dbn seems to work properly for me now
  • the only thing i changed was that the superclass model cpfs dict now has the format name: (objects, expr) instead of name: expr.. this was necessary to ensure that both grounded and lifted models can be interchanged in some code.
  • the objects are ignored for xadd because the domain is assumed grounded.
  • the only file i made a nontrivial change is the RDDLModelXADD, all other changes are cosmetic.
  • I have not checked the level analysis nor simulator, but I understand now this is not on the critical path.
  • please take a look at it and fix anything i missed.

@mike-gimelfarb mike-gimelfarb added bug Something isn't working Urgent Takes top priority among other pull requests labels Dec 19, 2022
@mike-gimelfarb mike-gimelfarb linked an issue Dec 19, 2022 that may be closed by this pull request
@jihwan-jeong jihwan-jeong merged commit 857e5be into main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Urgent Takes top priority among other pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix possibly broken XADD compilation due to new API changes
2 participants