Implement support for bitbucket ssh urls #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial fix for pyrech#23. Especially for private repositories on bitbucket.
|
Thanks for this PR. I never got ssh urls when using this plugin so I trust you on this one 😉 Build is failing because tests are broken on recent Composer versions since they changed a bit the plugin API (it impacts only the tests, not the plugin behavior). But tests pass with an older version so I'm enough confident to merge it as is. Thanks again! |
pyrech
added a commit
that referenced
this pull request
Feb 22, 2016
Implement support for bitbucket ssh urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #23.
Especially for private repositories on bitbucket.