Add support for gitlab repositories #37
Conversation
| "extra": { | ||
| "composer-changelogs": { | ||
| "gitlab-hosts": [ | ||
| "gitlab.my-company.org" |
There was a problem hiding this comment.
Why not using already existing composer configuration options like "github-domains" and "gitlab-domains" ?
There was a problem hiding this comment.
Hum, I didn't know these options existed.
@kitzberger can you confirm that you are using one of these options in your composer.json when using gitlab repositories?
There was a problem hiding this comment.
I haven't heard of that option up until now, so no, so far we're not using it at all. I don't think that I fully understand what "gitlab-domains" is exactly for. The docs refer to it only to be necessary when using the gitlab repository type which we're not doing. We're using a composer repository (Satis) instead.
But maybe @damienalexandre can give some further explanation ;-)
Apart from that does your code work as expected, @pyrech. Thanks for the effort!
There was a problem hiding this comment.
That's really nice to read, thanks for your feedback! 😉
Unless we got any cons, I will merge this PR tomorrow
pyrech
force-pushed
the
feature/support-gitlab
branch
from
0543907
to
90a4eeb
Compare
pyrech
force-pushed
the
feature/support-gitlab
branch
from
90a4eeb
to
2b36e56
Compare
Fixes #34
Gitlab instances can now be specified through the
gitlab-hostsconfig parameter. See the documentation to see how to setup it.