Fixed log_prob for negative correlation in SineBivariateVonMises
#1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehiepsi
reviewed
Dec 17, 2022
numpyro/distributions/directional.py
Outdated
| @@ -400,7 +400,7 @@ def norm_const(self): | |||
|
|
|||
| fs = ( | |||
| lbinoms.reshape(-1, 1) | |||
| + 2 * m * jnp.log(corr) | |||
| + m * jnp.log(corr**2) | |||
There was a problem hiding this comment.
Nice catch! I guess you can clip by tiny here in case users set corr=0?
There was a problem hiding this comment.
Sure, that makes sense.
fehiepsi
reviewed
Dec 17, 2022
fehiepsi
previously approved these changes
Dec 17, 2022
numpyro/distributions/directional.py
Outdated
| + 2 * m * jnp.log(corr) | ||
| - m * jnp.log(4 * jnp.prod(conc, axis=-1)) | ||
| fs = lbinoms.reshape(-1, 1) + m * ( | ||
| jnp.log(jnp.clip(corr**2, a_min=jnp.finfo(float).tiny)) |
There was a problem hiding this comment.
The float finfo is too small for single precision, how about jnp.finfo(jnp.result_type(float)).tiny?
fehiepsi
approved these changes
Dec 17, 2022
This was referenced Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes bias on correlation in
SBvMnormalization and fixesNaNin normalization for negative correlation (corr < 0.).From #1511.