Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sample option to pyro.contrib.funsor.infer_discrete #2789

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

eb8680
Copy link
Member

@eb8680 eb8680 commented Mar 24, 2021

pair coded with @fritzo
Blocked by #2781

@fritzo
Copy link
Member

fritzo commented Mar 24, 2021

@eb8680 I think this is ready to switch merge target and review now

@eb8680 eb8680 changed the base branch from contrib-funsor-infer-discrete to dev March 24, 2021 22:46
@eb8680 eb8680 marked this pull request as ready for review March 24, 2021 22:46
@eb8680 eb8680 force-pushed the contrib-funsor-infer-discrete-sample branch from 0d16986 to e514fea Compare March 24, 2021 22:49
@eb8680 eb8680 removed the Blocked label Mar 24, 2021
@eb8680 eb8680 requested a review from fritzo March 24, 2021 22:52
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@fritzo fritzo merged commit 9e1fd39 into dev Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants