Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logistic distribution #2895

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Add Logistic distribution #2895

merged 1 commit into from
Jul 6, 2021

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Jul 5, 2021 •
edited
Loading

Addresses pytorch/pytorch#7857

This aims to replace the less standard SoftLaplace distribution of #2791 and #2800 .

image

Tested

  • added test examples to tests/distributions/conftest.py

@fritzo fritzo added this to the 1.7 release milestone Jul 5, 2021
@fritzo fritzo requested a review from fehiepsi July 5, 2021 21:50
fehiepsi
fehiepsi approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It is surprising that this distribution is not yet available in PyTorch.

@fehiepsi fehiepsi merged commit 21f6716 into dev Jul 6, 2021
@fritzo fritzo deleted the logistic-distribution branch September 27, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
awaiting review enhancement
Projects
None yet
Milestone
1.7 release
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzo @fehiepsi