Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified comments in minipyro.py to fix #3003 #3004

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Conversation

luiarthur
Copy link
Contributor

@luiarthur luiarthur commented Jan 12, 2022

Applied changes proposed in #3003.

Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR! Looks great, I just have one question about terminology

pyro/contrib/minipyro.py Outdated Show resolved Hide resolved
@luiarthur
Copy link
Contributor Author

Hi @fritzo. Thanks for reviewing the PR. I've made the changes so that the terms used to describe the location of the handlers in the stack are higher/lower instead of a mixture of higher/lower and earlier/later.

Let me know if you have any other suggestions.

@fritzo fritzo merged commit b134ae8 into pyro-ppl:dev Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants