Some documentation improvements to MLE_MAP and SVI_P #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed beta distribution to Beta distribution - Changed bernoulli to Bernoulli - Add analytical MLE expression and show learnt MLE is same as analytical MLE - Add analytical MAP expression and show learnt MAP is same as analytical MAP - render_model() showing the graphical models and how they differ for MLE and MAP model - use uniform prior additionally for MAP model and show MAP = MLE - Show neg loglikelihood(optimum) = SVI loss for MLE (optimum)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
fritzo
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
These look like great improvements to the tutorials, @nipunbatra!
|
Many thanks for accepting this PR and guiding throughout! Do the docs take some time to update? I still see the docs without the changes from this PR. Or, does the docs update need a manual push? |
The api docs at https://docs.pyro.ai are updated automatically after a few minutes. The tutorials at https://pyro.ai/examples are updated manually after each release (we do that to ensure the tutorials are all compatible with the latest Pyro release). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVI Part 1
MLE MAP
Closes #3019