Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAE: Improved ELBO plots #3205

Merged
merged 1 commit into from
May 6, 2023
Merged

Conversation

martinrohbeck
Copy link
Contributor

@martinrohbeck martinrohbeck commented May 1, 2023

Hey there,

this PR corrects and improves the plots in the Pyro VAE tutorial.

There seem to be three minor hiccups in the code:

  • It looks like you are plotting the Test ELBO but with training epochs on the x-axis, here
  • The size argument here does not exist in the current seaborn version anymore and raises an error.
  • Currently both train and test ELBOs are passed to plot_llk, but only the test ELBO values are plotted. I guess this is not intended.

The PR plots both train and test performance and ensures ELBOs are correctly aligned with the epochs (even if ELBOs are computed at different frequencies) and moves the plotting function call into the if statement when the data is actually evaluated on the test data.

I did not open a PR because this is a minor correction -- hope that's fine with you.

New example plot:
image

@martinrohbeck martinrohbeck changed the title Fixed ELBO plots, added ELBO on training data VAE: Improved ELBO plots May 1, 2023
@fritzo fritzo merged commit 954ac97 into pyro-ppl:dev May 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants