Clear .unconstrained weakrefs before pickling; rebuild them more often #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
commented
May 17, 2023
| @@ -75,3 +76,22 @@ def iter_plates_to_shape(shape): | |||
| # Go backwards (right to left) | |||
| for i, s in enumerate(shape[::-1]): | |||
| yield pyro.plate("plate_" + str(i), s) | |||
|
|
|||
|
|
|||
| def check_no_weakref(obj, path="", avoid_ids=None): | |||
There was a problem hiding this comment.
This is just a helper to debug similar issues in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3201
Replaces #3206
This builds on @ilia-kats's diagnosis of why
torch.saveis failing with various Pyro objects in torch>=2, namely that the.unconstrainedattributes of tensors are breaking pickling. This PR:.unconstrainedin one other place,.unconstrainedin one place,__getstate__in a number of places to avoid serializingweakref.refsTested