Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable pdf builds on readthedocs #3250

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Disable pdf builds on readthedocs #3250

merged 1 commit into from
Jul 26, 2023

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Jul 25, 2023 •
edited
Loading

Resolves #3248 by disabling pdf builds on readthedocs.

I'd like to merge this branch into dev, then examine the build status on readthedocs. (I don't know a simpler way to test readthedocs builds 🤷)

@fritzo fritzo added the WIP label Jul 25, 2023
@fritzo fritzo added this to the 1.8.6 release milestone Jul 25, 2023
martinjankowiak
martinjankowiak approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@martinjankowiak martinjankowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me. i've certainly never used the pdf docs....

@fritzo
Copy link
Member Author

fritzo commented Jul 26, 2023

Thanks @martinjankowiak could you merge please?

@martinjankowiak martinjankowiak merged commit 49d0b92 into dev Jul 26, 2023
9 checks passed
@fritzo fritzo deleted the docs-no-latex branch August 10, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjankowiak martinjankowiak martinjankowiak approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
1.8.6 release
Development

Successfully merging this pull request may close these issues.

Docs builds are failing
2 participants
@fritzo @martinjankowiak