Type annotate broadcast, condition, do, enum messengers #3295
Conversation
| @@ -76,7 +78,11 @@ def _pyro_sample(self, msg): | |||
| intervention = self.data[msg["name"]] | |||
| msg["name"] = msg["name"] + "__CF" # mangle old name | |||
|
|
|||
| if isinstance(intervention, (numbers.Number, torch.Tensor)): | |||
| if isinstance(intervention, numbers.Number): | |||
| msg["value"] = torch.tensor(intervention) | |||
There was a problem hiding this comment.
It might be a good idea to constrain msg["value"] to be torch.Tensor because in many places it is expected to be a torch.Tensor by attempting to access torch.Tensor attributes.
There was a problem hiding this comment.
@eb8680 can you make sure this is safe? We don't want to break any Chirho code.
|
|
||
| # if this site has any ancestors, choose ancestors from diagonal approximation | ||
| thin_sample = fat_sample | ||
| if thin_sample.shape != target_shape: | ||
| index = [Ellipsis] + [slice(None)] * (len(thin_sample.shape) - 1) | ||
| index: List[Any] = [Ellipsis] + [slice(None)] * (len(thin_sample.shape) - 1) |
There was a problem hiding this comment.
This can be narrowed down once we annotate Vindex
| @@ -27,7 +28,7 @@ class TorchDistributionMixin(Distribution): | |||
| from :class:`TorchDistributionMixin`. | |||
| """ | |||
|
|
|||
| def __call__(self, sample_shape: torch.Size = torch.Size()) -> torch.Tensor: | |||
| def __call__(self, sample_shape: Tuple[int] = torch.Size()) -> torch.Tensor: | |||
There was a problem hiding this comment.
Are you sure this is safe? There are a few places in Pyro where an actual torch.Size object is required, as it has special methods like .numel. Just checking 🙂
There was a problem hiding this comment.
Actually, not sure about it. Changed it back and adjusted elsewhere to convert tuple arguments into torch.Size
| @@ -76,7 +78,11 @@ def _pyro_sample(self, msg): | |||
| intervention = self.data[msg["name"]] | |||
| msg["name"] = msg["name"] + "__CF" # mangle old name | |||
|
|
|||
| if isinstance(intervention, (numbers.Number, torch.Tensor)): | |||
| if isinstance(intervention, numbers.Number): | |||
| msg["value"] = torch.tensor(intervention) | |||
There was a problem hiding this comment.
@eb8680 can you make sure this is safe? We don't want to break any Chirho code.
No description provided.