Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mypy warn_unreachable=True #3312

Merged
merged 10 commits into from
Jan 17, 2024
Merged

Mypy warn_unreachable=True #3312

merged 10 commits into from
Jan 17, 2024

Conversation

ordabayevy
Copy link
Member

@ordabayevy ordabayevy commented Jan 7, 2024 •
edited

  • Add warn_unreachable=True flag
  • Add None return type to __init__s
  • Use if TYPE_CHECKING: whenever possible
  • collapse_messenger
  • markov_messenger
  • replay_messenger

@ordabayevy ordabayevy changed the title Mypy warn_uncreachable=True Mypy warn_unreachable=True Jan 7, 2024
@ordabayevy ordabayevy added the WIP label Jan 7, 2024
ordabayevy
ordabayevy commented Jan 16, 2024
View reviewed changes
pyro/poutine/collapse_messenger.py

@_get_free_vars.register(tuple)
def _(x, subs):
return frozenset().union(*map(_get_free_vars, x))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem to be obsolete

fritzo
fritzo approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's great to see these type hints and to see some obsolete code deleted!

@fritzo fritzo merged commit c0b36f1 into dev Jan 17, 2024
9 checks passed
@ordabayevy ordabayevy deleted the warn-uncreachable branch January 17, 2024 03:10
@ordabayevy ordabayevy mentioned this pull request Feb 5, 2024
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzo fritzo fritzo approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ordabayevy @fritzo