Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get CI working with new black, torch, pytest #3318

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Get CI working with new black, torch, pytest #3318

merged 9 commits into from
Feb 2, 2024

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Feb 1, 2024

Blocking #3317

This PR performs a number of maintenance tasks to get our CI working again.

  1. Update black and reformat, completely automated. I haven't bumped black's version pin.
pip install -U black
make format
  1. Use torch.distributions.InverseGamma if available.
    This was breaking our docs build.
    I've marked our old InverseGamma for deprecation.
  2. Mark test_benchmark.py as stage=benchmark to avoid a new pytest warning.
  3. Changes test_welford.py and the CEVAE's prewhitener to avoid a new .var() warning in torch.

@fritzo fritzo added awaiting review and removed WIP labels Feb 1, 2024
@fritzo fritzo changed the title Run make format after updating black Get CI working with new black, torch, pytest Feb 1, 2024
@fritzo
Copy link
Member Author

fritzo commented Feb 2, 2024

Phew, looks like this is now ready to merge 😅

Copy link
Member

@ordabayevy ordabayevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this @fritzo !

@fritzo fritzo merged commit df34383 into dev Feb 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants