Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added proper scopes to media routes #118

Merged
merged 4 commits into from
Mar 18, 2021
Merged

feat: Added proper scopes to media routes #118

merged 4 commits into from
Mar 18, 2021

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Mar 15, 2021

Following up on #45, this PR introduces the following modifications:

  • renamed the media upload route
  • added admin scope to media get and fetch routes
  • reindented the table in the media route

Any feedback is welcome!

Note: I think there is an issue with our unittests regarding Security/get_current_access. When I test it manually, the changes from this PR do work. But this means that the current unittests should fail (because the default current access doesn't have admin scope). I'll open an issue about this #119

@frgfm frgfm added this to the 0.1.2 milestone Mar 15, 2021
@frgfm frgfm self-assigned this Mar 15, 2021
@frgfm frgfm mentioned this pull request Mar 15, 2021
9 tasks
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #118 (f397f66) into master (a139a8c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files          27       27           
  Lines         787      787           
=======================================
  Hits          695      695           
  Misses         92       92           
Flag Coverage Δ
unittests 88.31% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/api/routes/media.py 87.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a139a8c...f397f66. Read the comment docs.

@frgfm frgfm merged commit 3587cdf into master Mar 18, 2021
@frgfm frgfm deleted the media-scope branch March 18, 2021 16:03
@frgfm frgfm added the type: improvement New feature or request label Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants