Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): add workflow to push image to Dockerhub #320

Closed
wants to merge 8 commits into from

Conversation

RonanMorgan
Copy link
Collaborator

@RonanMorgan RonanMorgan commented Apr 24, 2024

II have created a test env which will be launched every night so it would be good to update our image in dockerhub regularly

@RonanMorgan RonanMorgan self-assigned this Apr 24, 2024
@RonanMorgan RonanMorgan marked this pull request as draft April 24, 2024 09:02
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.34%. Comparing base (767be30) to head (2c4e136).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   94.54%   94.34%   -0.21%     
==========================================
  Files          63       66       +3     
  Lines        1594     1679      +85     
==========================================
+ Hits         1507     1584      +77     
- Misses         87       95       +8     
Flag Coverage Δ
client 90.58% <ø> (?)
unittests 94.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RonanMorgan RonanMorgan marked this pull request as ready for review April 24, 2024 09:12
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Only a slight issue on the action trigger I think :)

.github/workflows/build-push-image.yml Outdated Show resolved Hide resolved
@frgfm frgfm changed the title Add gitAction for pushing image ci(github): add workflow to push image to Dockerhub Apr 25, 2024
frgfm
frgfm previously approved these changes May 4, 2024
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@RonanMorgan RonanMorgan removed the request for review from MateoLostanlen May 13, 2024 07:36
@RonanMorgan RonanMorgan requested a review from frgfm May 22, 2024 11:58
@frgfm frgfm added the duplicate This issue or pull request already exists label Aug 23, 2024
@frgfm
Copy link
Member

frgfm commented Aug 23, 2024

Oops, I just remember we already had this! The workflow trigger was not changed properly recently, but I pushed a fix a few hours ago #360

Images are now pushed again to the hub so I think we can close this PR :)
Feel free to reopen if I missed something!

@frgfm frgfm closed this Aug 23, 2024
@frgfm frgfm deleted the rs/create-gitAction-push branch August 23, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists type: feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants