-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(github): add workflow to push image to Dockerhub #320
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
- Coverage 94.54% 94.34% -0.21%
==========================================
Files 63 66 +3
Lines 1594 1679 +85
==========================================
+ Hits 1507 1584 +77
- Misses 87 95 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Only a slight issue on the action trigger I think :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers!
Oops, I just remember we already had this! The workflow trigger was not changed properly recently, but I pushed a fix a few hours ago #360 Images are now pushed again to the hub so I think we can close this PR :) |
II have created a test env which will be launched every night so it would be good to update our image in dockerhub regularly