Install of vision dependencies #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloeskt
requested changes
Mar 23, 2021
chloeskt
reviewed
Mar 23, 2021
|
Thank you @fe51 for this PR, looks good for me 🤗 |
chloeskt
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This PR add playbook to install vision dependencies for raspberry set up
Motivation
As central pi will performed inference, it relies on packages required in pyro-vision
Following issue pyronear/pyro-vision#113, versions of pytorch and torchvision packages compiled for ARM processor are available in the release V0.1.1 of pyro-vison
Those package needs to be installed at set up on central pi.
Hence, the following PR introduces a playbook that initiate pyro-vision dependences.
So far, version of package is hardcoded in the url. We could consider add variable and especially get the latest version of packages from the latest release of pyro-vision (via https://api.github.com ). However, it might introduce less stability.
Also, I was hesitating where I should create a dedicated role and add it to common_playbooks or creating a dedicated playbook and import it in the master playbook.
Any feedback are welcomed