Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesystem: First validate objectives #800

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

metalmatze
Copy link
Member

Pyrra's filesystem component is now going to validate the given config file. If there is an error it will be returned and logged. Nothing will be done with that file. If there are warnings, the warnings will be logged, but the Prometheus rules are generated.

These metrics are increased and can be alerted on too:

# HELP pyrra_filesystem_reconciles_errors_total The total amount of errors during reconciles.
# TYPE pyrra_filesystem_reconciles_errors_total counter
pyrra_filesystem_reconciles_errors_total 7
# HELP pyrra_filesystem_reconciles_total The total amount of reconciles.
# TYPE pyrra_filesystem_reconciles_total counter
pyrra_filesystem_reconciles_total 23

Pyrra's filesystem component is now going to validate the given config file. If there is an error it will be returned and logged. Nothing will be done with that file. If there are warnings, the warnings will be logged, but the Prometheus rules are generated.
Base automatically changed from validation-webhook to main July 12, 2023 09:03
@metalmatze metalmatze merged commit ed7c901 into main Jul 12, 2023
@metalmatze metalmatze deleted the filesystem-validation branch July 12, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant