Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release coordination #631

Open
martinfleis opened this issue Nov 6, 2023 · 6 comments
Open

Release coordination #631

martinfleis opened this issue Nov 6, 2023 · 6 comments
Assignees

Comments

@martinfleis
Copy link
Member

Recent changes that made it to 4.9.2 caused a lot of trouble at many places.

Considering all of this, I believe that we need to put in place additional checks before making a release of libpysal. A subset of that could be also applied elsewhere, to ensure that we don't break our own ecosystem.

@knaaptime
Copy link
Member

as a first cut, we should probably make sure that all the subpackages test against libpysal@main (like esda), and that downstream tests pass before a new libpysal is released

@knaaptime
Copy link
Member

knaaptime commented Nov 6, 2023

we have not updated requirements on conda-forge (conda-forge/libpysal-feedstock#23) which resulted in 4.9.2 being installed in Python 3.9 and 3.8. environments while being incompatible with those

i think the other way to handle this is to turn off automerge. While i like automerge, there's no way to control something like the minimum dependency change we just encountered (unless you catch the recipe PR before the bot merges). When we issue a new release, the CI can guarantee the dependencies are correct in the source code, but theres no way to force the conda-forge recipe to use those deps

@martinfleis
Copy link
Member Author

Automerge wasn't on.

@jGaboardi
Copy link
Member

This specific time did not have to do with automerge, unfortunately. The PR passed, so I merged it 😞.

@knaaptime
Copy link
Member

knaaptime commented Nov 6, 2023

(but its turned on now)

EDIT: actually, is it? its defined twice in here

@martinfleis
Copy link
Member Author

Ah, my bad! Then it probably was on and I just missed it. The PR was merged manually though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants