-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release coordination #631
Comments
as a first cut, we should probably make sure that all the subpackages test against libpysal@main (like esda), and that downstream tests pass before a new libpysal is released |
i think the other way to handle this is to turn off automerge. While i like automerge, there's no way to control something like the minimum dependency change we just encountered (unless you catch the recipe PR before the bot merges). When we issue a new release, the CI can guarantee the dependencies are correct in the source code, but theres no way to force the conda-forge recipe to use those deps |
Automerge wasn't on. |
This specific time did not have to do with automerge, unfortunately. The PR passed, so I merged it 😞. |
(but its turned on now) EDIT: actually, is it? its defined twice in here |
Ah, my bad! Then it probably was on and I just missed it. The PR was merged manually though. |
Recent changes that made it to 4.9.2 caused a lot of trouble at many places.
libpysal.common
spreg#129) which wrongly did star imports from libpysal.common and used numpy imported from there instead of their ownimport numpy as np
code. While we noticed this immediately, we released 4.9.2 without keeping track of these issues which then broke production environments.Considering all of this, I believe that we need to put in place additional checks before making a release of libpysal. A subset of that could be also applied elsewhere, to ensure that we don't break our own ecosystem.
The text was updated successfully, but these errors were encountered: