Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt imports to update in libpysal.common #129

Merged
merged 1 commit into from
Nov 7, 2023
Merged

adapt imports to update in libpysal.common #129

merged 1 commit into from
Nov 7, 2023

Conversation

jGaboardi
Copy link
Member

This PR resolves #128

@jGaboardi jGaboardi added the bug Something isn't working label Oct 24, 2023
@jGaboardi jGaboardi self-assigned this Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #129 (ae8a959) into main (c0ead26) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #129   +/-   ##
=====================================
  Coverage   69.1%   69.1%           
=====================================
  Files         40      40           
  Lines       8723    8727    +4     
  Branches    1253    1253           
=====================================
+ Hits        6024    6028    +4     
  Misses      2319    2319           
  Partials     380     380
Files Coverage Δ
spreg/diagnostics.py 86.0% <100.0%> (+0.1%) ⬆️
spreg/diagnostics_tsls.py 87.9% <100.0%> (+0.4%) ⬆️

martinfleis
martinfleis approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a patch release soon. This currently breaks fresh environments.

The CI issue in Python 3.9 shown on main is being patched on conda-forge and can be ignored here.

@martinfleis martinfleis mentioned this pull request Nov 6, 2023
Open
@knaaptime knaaptime merged commit bf21724 into pysal:main Nov 7, 2023
9 checks passed
@jGaboardi jGaboardi deleted the fix_import_bug branch November 7, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knaaptime knaaptime knaaptime approved these changes

@martinfleis martinfleis martinfleis approved these changes

@pedrovma pedrovma Awaiting requested review from pedrovma

@sjsrey sjsrey Awaiting requested review from sjsrey

Assignees

@jGaboardi jGaboardi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failures due to update in libpysal.common
3 participants
@jGaboardi @knaaptime @martinfleis