Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intercept Coincident points #548

Merged
merged 37 commits into from
Aug 25, 2023
Merged

Intercept Coincident points #548

merged 37 commits into from
Aug 25, 2023

Commits on Aug 10, 2023

  1. [WIP] start intercepting coincidence, probably should use a decorator… 

    … instead
    @ljwolf
    ljwolf committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    a5c63c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. finalize decorator implementation for _triangulation

    @ljwolf
    ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    b22f2e5 View commit details
    Browse the repository at this point in the history

  2. finish jitter implementation

    @ljwolf
    ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    8aac540 View commit details
    Browse the repository at this point in the history

  3. propagate coincident to build_triangulation

    @ljwolf
    ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d0b7c0d View commit details
    Browse the repository at this point in the history

  4. add reasons to assert clauses

    @ljwolf
    ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ca5ec9a View commit details
    Browse the repository at this point in the history

  5. voronoi should still admit kernels

    @ljwolf
    ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    36a18e3 View commit details
    Browse the repository at this point in the history

  6. move to None for defaults, not boxcar/inf

    @ljwolf
    ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2745af4 View commit details
    Browse the repository at this point in the history

  7. add distance_band

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    e1b243a View commit details
    Browse the repository at this point in the history

  8. channel distance band through kernel

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    cda1ef9 View commit details
    Browse the repository at this point in the history

  9. fix isolates in distance band

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ab207dd View commit details
    Browse the repository at this point in the history

  10. lag, parquet IO, __getitem__, block placeholder

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d4f6c73 View commit details
    Browse the repository at this point in the history

  11. docstrings, optional pyarrow

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3e20546 View commit details
    Browse the repository at this point in the history

  12. fix test

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    6ac2b7c View commit details
    Browse the repository at this point in the history

  13. block contiguity

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    bed12a8 View commit details
    Browse the repository at this point in the history

  14. add tests

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    7671b77 View commit details
    Browse the repository at this point in the history

  15. to-dos

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f6ecc00 View commit details
    Browse the repository at this point in the history

  16. Apply suggestions from code review 

    Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
    @martinfleis @jGaboardi @ljwolf
    2 people authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    6f283f8 View commit details
    Browse the repository at this point in the history

  17. test block_contiguity

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c25db44 View commit details
    Browse the repository at this point in the history

  18. test parquet without meta

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3d27594 View commit details
    Browse the repository at this point in the history

  19. test lag

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ea180bd View commit details
    Browse the repository at this point in the history

  20. haversine todo note

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    017ef80 View commit details
    Browse the repository at this point in the history

  21. comment on diag

    @martinfleis @ljwolf
    martinfleis authored and ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d30f63b View commit details
    Browse the repository at this point in the history

  22. [WIP] work through integrations of kernel and triangulation in prep t… 

    …o rebase
    @ljwolf
    ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1754691 View commit details
    Browse the repository at this point in the history

  23. move back to upstream kernel

    @ljwolf
    ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c318989 View commit details
    Browse the repository at this point in the history

  24. migrate checks for arrays, complete test battery

    @ljwolf
    ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    fff6587 View commit details
    Browse the repository at this point in the history

  25. Merge remote-tracking branch 'upstream/geographs' into geographs

    @ljwolf
    ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a8be157 View commit details
    Browse the repository at this point in the history

  26. fix docstrings

    @ljwolf
    ljwolf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c5cbe32 View commit details
    Browse the repository at this point in the history

  27. Update libpysal/graph/_triangulation.py 

    Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
    @ljwolf @jGaboardi
    ljwolf and jGaboardi authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    36d88b0 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. document coincident option for graph

    @sjsrey
    sjsrey committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    2f18e35 View commit details
    Browse the repository at this point in the history

  2. add coincidence checks to knn

    @ljwolf
    ljwolf committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    d946fec View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from sjsrey/ljwgeographs 

    document coincident option for graph
    @ljwolf
    ljwolf authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    de99dd5 View commit details
    Browse the repository at this point in the history

  4. Update libpysal/graph/_utils.py 

    Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
    @ljwolf @jGaboardi
    ljwolf and jGaboardi authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    6bdd4bc View commit details
    Browse the repository at this point in the history

  5. Update libpysal/graph/_utils.py 

    Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
    @ljwolf @jGaboardi
    ljwolf and jGaboardi authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    008b0e8 View commit details
    Browse the repository at this point in the history

  6. Update libpysal/graph/_utils.py 

    Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
    @ljwolf @jGaboardi
    ljwolf and jGaboardi authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    ae59ad7 View commit details
    Browse the repository at this point in the history

  7. finalize coincident checks in knn

    @ljwolf
    ljwolf committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    cbf309b View commit details
    Browse the repository at this point in the history

  8. add the reorder table function to base, prepare for sorting inputs to… 

    … weights
    @ljwolf
    ljwolf committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    82f3e18 View commit details
    Browse the repository at this point in the history

  9. handle ids is none

    @ljwolf
    ljwolf committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c4383e1 View commit details
    Browse the repository at this point in the history