-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove xarray
as hard dependency
#629
Conversation
So with these two failures in |
Codecov Report
@@ Coverage Diff @@
## main #629 +/- ##
=====================================
Coverage 84.5% 84.5%
=====================================
Files 139 139
Lines 14967 14972 +5
=====================================
+ Hits 12642 12647 +5
Misses 2325 2325
|
So unless I am missing something obvious we have 2 choices here:
|
@knaaptime OK, CI running now. Sorry for the confusion 🤣 |
refactor mixin
So is this PR good to merge? And after merge shall we cut a |
i think this is a bugfix (and we're changing the dependencies) so id do 492. I think its probably ready to go, but was gonna wait for martin to have a look since you and i both touched the pr |
Agreed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending green ci :)
This PR removes
xarray
as hard dependency, which is causing feedstock failures