Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the links around figures in the JOSS paper #99

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Remove the links around figures in the JOSS paper #99

merged 1 commit into from
Mar 4, 2020

Conversation

leouieda
Copy link
Contributor

@leouieda leouieda commented Feb 5, 2020

Include the links in the figure caption instead to avoid issues when compiling the paper PDF.

You can preview the compiled paper at: http://res.cloudinary.com/hju22ue2k/image/upload/v1580414535/wvsuqwnyi5rgshtoru7i.pdf

The "Figure 1" etc are added automatically when compiling the paper. I used the link to the master branch notebook but this is probably not ideal since that link will break if the notebooks are moved. It would be best to link to the specific version used in the JOSS paper (feel free to update this branch).

openjournals/joss-reviews#1882

  1. You have run tests on this submission, either by using Travis Continuous Integration testing testing or running nosetests on your changes?
  2. This pull request is directed to the pysal/dev branch.
  3. This pull introduces new functionality covered by
    docstrings and
    unittests?
  4. You have assigned a
    reviewer
    and added relevant labels
  5. The justification for this PR is:

Include the links in the figure caption instead to avoid issues when 
compiling the paper PDF.
@leouieda
Copy link
Contributor Author

@slumnitz any updates on this?

@jGaboardi
Copy link
Member

@leouieda I think she is still experiencing issues with a reliable internet connection.

@leouieda
Copy link
Contributor Author

@jGaboardi thank you for the update. I was mostly checking in on the progress. We're done with the review and this is mostly the only thing left for the paper to be accepted. No rush, though. Let me know this is ready to move forward.

@ljwolf
Copy link
Member

ljwolf commented Feb 27, 2020

This should be very easy to address. I will try to complete it this week

@ljwolf ljwolf merged commit 489ab26 into pysal:master Mar 4, 2020
@ljwolf
Copy link
Member

ljwolf commented Mar 4, 2020

Thanks @leouieda! This looks complete to me.

@slumnitz slumnitz mentioned this pull request Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants