Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utilize BaseSpOptExactSolver #305

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

jGaboardi
Copy link
Member

This PR removes the ortools import in BaseClass so that BaseSpOptExactSolver can then be inherited by LocateSolver instances.

xref #298 #49

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #305 (a0e8465) into main (21fe3e0) will increase coverage by 0.2%.
The diff coverage is 75.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #305     +/-   ##
=======================================
+ Coverage   73.7%   73.9%   +0.2%     
=======================================
  Files         23      23             
  Lines       2421    2417      -4     
  Branches     463     463             
=======================================
+ Hits        1785    1786      +1     
+ Misses       578     573      -5     
  Partials      58      58             
Impacted Files Coverage Δ
spopt/BaseClass.py 73.3% <50.0%> (+20.7%) ⬆️
spopt/locate/base.py 95.1% <100.0%> (ø)

@jGaboardi jGaboardi merged commit b4044bb into pysal:main Nov 21, 2022
@jGaboardi jGaboardi deleted the remove_ortools branch November 21, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants