Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc work and formatting continued (random_region, util, ward) #307

Merged
merged 9 commits into from
Dec 11, 2022

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Nov 21, 2022

This PR continues pushing towards a completion of #173 --> #280 and covers:

  • random_region.py
  • util.py
  • ward.py

@jGaboardi jGaboardi added maintenance WIP Work in progress. For discussion and feedback. Do not merge. docs labels Nov 21, 2022
@jGaboardi jGaboardi self-assigned this Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #307 (480d12c) into main (b4044bb) will decrease coverage by 0.0%.
The diff coverage is 63.2%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #307     +/-   ##
=======================================
- Coverage   73.9%   73.9%   -0.0%     
=======================================
  Files         23      23             
  Lines       2417    2411      -6     
  Branches     463     463             
=======================================
- Hits        1786    1781      -5     
+ Misses       573     572      -1     
  Partials      58      58             
Impacted Files Coverage Δ
spopt/region/base.py 97.6% <ø> (ø)
spopt/region/util.py 58.0% <50.0%> (+0.3%) ⬆️
spopt/region/random_region.py 96.8% <83.3%> (-0.1%) ⬇️
spopt/region/ward.py 100.0% <100.0%> (ø)

@jGaboardi jGaboardi changed the title [WIP] doc work and formatting continued doc work and formatting continued (random_region, util, ward) Nov 22, 2022
@jGaboardi jGaboardi removed the WIP Work in progress. For discussion and feedback. Do not merge. label Nov 22, 2022
@jGaboardi
Copy link
Member Author

This is ready for a review when you have a moment, @sjsrey.

@sjsrey sjsrey merged commit f3066c8 into pysal:main Dec 11, 2022
@jGaboardi jGaboardi deleted the ward_rr_docs branch December 11, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants