Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline redundant parameter passing in constraint constructors #319

Merged
merged 5 commits into from
Dec 25, 2022

Conversation

jGaboardi
Copy link
Member

This PR resolves #317; there is no change to actual functionality.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #319 (4565f4f) into main (8e6b192) will increase coverage by 0.2%.
The diff coverage is 97.8%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #319     +/-   ##
=======================================
+ Coverage   73.8%   74.0%   +0.2%     
=======================================
  Files         23      23             
  Lines       2456    2474     +18     
  Branches     476     476             
=======================================
+ Hits        1812    1830     +18     
  Misses       579     579             
  Partials      65      65             
Impacted Files Coverage Δ
spopt/locate/p_dispersion.py 100.0% <ø> (ø)
spopt/locate/coverage.py 95.6% <93.3%> (+<0.1%) ⬆️
spopt/locate/base.py 93.6% <100.0%> (+0.6%) ⬆️
spopt/locate/p_center.py 100.0% <100.0%> (ø)
spopt/locate/p_median.py 100.0% <100.0%> (ø)

@jGaboardi
Copy link
Member Author

jGaboardi commented Dec 22, 2022

@sjsrey & @gegen07 I'd like to get this merged then I can knock out #318 before I circle back on some CLSCP-SO clean-up & example stuff I am working on (xref #320). Either of you have time for a quick review?

Copy link
Member

@gegen07 gegen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gegen07 gegen07 merged commit 8fce892 into pysal:main Dec 25, 2022
@jGaboardi jGaboardi deleted the streamline_var_constr branch December 25, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

streamline variable and constraint creation
2 participants