Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul repo infrastructure #353

Merged
merged 16 commits into from
Mar 2, 2023
Merged

Overhaul repo infrastructure #353

merged 16 commits into from
Mar 2, 2023

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Feb 26, 2023 •
edited
Loading

This PR:

@jGaboardi jGaboardi self-assigned this Feb 26, 2023
martinfleis
martinfleis reviewed Feb 28, 2023
View reviewed changes
.ci/311-DEV.yaml Outdated Show resolved Hide resolved
@jGaboardi
Copy link
Member Author

@martinfleis Any chance for a review on this? 99.99% infrastructure/formatting changes and no changes in code functionality.

martinfleis
martinfleis reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note in code.

The CI failure is expected?

Can you make sure that pre-commit.ci is green?

.github/workflows/testing.yml Outdated Show resolved Hide resolved
@jGaboardi jGaboardi mentioned this pull request Feb 28, 2023
Closed
@jGaboardi
Copy link
Member Author

The CI failure is expected?

The CI failure is recorded in #346 and only started with pysal/libpysal#511. I haven't been able to track down the reason.

@jGaboardi
Copy link
Member Author

Can you make sure that pre-commit.ci is green?

Oh man. Not sure how this fell through the cracks. The PR had been passing ruff+black locally for me, not sure how all these got reverted. I'll look into it.

@jGaboardi
Copy link
Member Author

pre-commit.ci is now back to green.

@jGaboardi
Copy link
Member Author

ugh... many more failures after ruffing.

@jGaboardi
Copy link
Member Author

@martinfleis All tests back to green (except the 'expected' 3.11-DEV' failure) after my ruffing debacle. Thanks for your patience.

martinfleis
martinfleis reviewed Mar 2, 2023
View reviewed changes
.ci/311-DEV.yaml Outdated Show resolved Hide resolved
martinfleis
martinfleis approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks!

@jGaboardi jGaboardi merged commit 151f5cb into pysal:main Mar 2, 2023
@jGaboardi jGaboardi deleted the format_lint_repo branch March 2, 2023 14:19
@jGaboardi jGaboardi mentioned this pull request Mar 15, 2023
Closed
@jGaboardi jGaboardi mentioned this pull request May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

Assignees

@jGaboardi jGaboardi

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generate report for CI failure adopt pyproject.toml
2 participants
@jGaboardi @martinfleis