Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failures due to update in libpysal.common #128

Closed
jGaboardi opened this issue Oct 24, 2023 · 1 comment · Fixed by #129
Closed

failures due to update in libpysal.common #128

jGaboardi opened this issue Oct 24, 2023 · 1 comment · Fixed by #129
Assignees
@jGaboardi
Labels
bug Something isn't working

Comments

@jGaboardi
Copy link
Member

Failures due to update in libpysal.common. Should be accessing packages directly when possible and also not with * import if possible (xref pysal/libpysal#599)

spreg/spreg/diagnostics.py

Line 9 in c0ead26

from libpysal.common import *

xref: pysal/libpysal#597, pysal/libpysal#605, pysal/esda#271
@jGaboardi jGaboardi added the bug Something isn't working label Oct 24, 2023
@jGaboardi jGaboardi self-assigned this Oct 24, 2023
@jGaboardi jGaboardi mentioned this issue Oct 24, 2023
Merged
@martinfleis
Copy link
Member

This has now propagated to fresh environments with libpysal 4.9.2 released yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jGaboardi jGaboardi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adapt imports to update in libpysal.common jGaboardi/spreg
2 participants
@jGaboardi @martinfleis