-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to version 1.6.0 #145
Conversation
The changes in this new version are: - Pandas objects (Series or DF) can now be passed as regression variables (y, x, yend, q, regimes), suppressing the need to explicitly provide their respective names in these cases. The names are automatically collected from the pandas objects. This applies to all regression functions. - Implementation of `Flexible WX`. Through a list of Booleans in argument `slx_vars`, the user can now select which x variables are to be lagged. This new feature applies to OLS, TSLS, ML and GM spatial models (both lag and error). - Kernel weights are now allowed in SLX and SDM models. - Added Durbin-Wu-Hausman test on endogeneity of variables to TSLS. - Spatial impacts are now computed for regression models with regimes. - Added VIF method to OLS results.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
+ Coverage 67.5% 67.6% +0.1%
=======================================
Files 41 41
Lines 9365 9626 +261
Branches 1370 1433 +63
=======================================
+ Hits 6320 6508 +188
- Misses 2651 2704 +53
- Partials 394 414 +20
|
Just a technical - this should probably be a 1.6.0 given there's new stuff coming, not 1.5.1 indicating a patch release as per semantic versioning. |
sweet. +1 on the 1.6 instead of 1.5.1 one quick question @pedrovma, is it possible to get impacts as a dataframe in the current API? specifically,
|
You are right! What you can get is model.sp_multipliers, a dictionary with the multipliers (direct, indirect, total). There is no attribute with a pandas object containing the spatial impacts. It is something we can consider adding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to add one test that sends a graph through the estimation, just to show that it works, but otherwise, great
|
snap :P 🙌 |
The changes in this new version are:
Pandas objects (Series or DF) can now be passed as regression variables (y, x, yend, q, regimes), suppressing the need to explicitly provide their respective names in these cases. The names are automatically collected from the pandas objects. This applies to all regression functions.
Implementation of
Flexible WX
. Through a list of Booleans in argumentslx_vars
, the user can now select which x variables are to be lagged. This new feature applies to OLS, TSLS, ML and GM spatial models (both lag and error).Kernel weights are now allowed in SLX and SDM models.
Added Durbin-Wu-Hausman test on endogeneity of variables to TSLS.
Spatial impacts are now computed for regression models with regimes.
Added VIF method to OLS results.
Added compatibility with libpysal.Graph.