Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Effects Panel - Spatial Lag #41

Merged
merged 15 commits into from
Jul 10, 2020
Merged

Conversation

pabloestradac
Copy link
Collaborator

@pabloestradac pabloestradac commented May 29, 2020

This pull request adds the estimation of fixed effects panel data of spatial lag models. It uses the class Panel_FE_Lag to estimate a spatial lag panel model with the direct approach of demeaned variables.

It also adds the functions of check_panel (based on Pedro's _get_panel_data function) and demean_panel located in panel_utils.py.

@weikang9009
Copy link
Member

Thanks for this @pabloestradac . Could you put together a Jupyter notebook explaining and demonstrating the added functionalities?

This notebook details the estimation of FE Panel in Spatial Lag models.
@pabloestradac pabloestradac linked an issue Jun 15, 2020 that may be closed by this pull request
@weikang9009
Copy link
Member

weikang9009 commented Jun 30, 2020

It seems that there is an error with the unit test spreg.tests.test_panel_fe.Test_Panel_FE_Lag https://travis-ci.org/github/pysal/spreg/jobs/703264975

@pabloestradac
Copy link
Collaborator Author

It seems it's fixed now. Thanks @weikang9009.

@weikang9009 weikang9009 merged commit 2d61285 into pysal:panel Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed Effects Panel - Spatial Lag model
2 participants