Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TST] conditionally skip 3.8 tests needing quilt #78

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

sjsrey
Copy link
Member

@sjsrey sjsrey commented Jul 12, 2020

It looks like quilt is not available for 3.8 on conda-forge:

image

So, I think that is why the ci couldn't solve for the testing env.

This PR starts some conditional skipping if quilt isn't available.

Looks to be working

To do

  • add warnings that quilt isn't available
  • update docs

@sjsrey sjsrey added the WIP Work in progress, do not merge label Jul 12, 2020
@sjsrey sjsrey requested a review from knaaptime July 12, 2020 21:05
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2020

Codecov Report

Merging #78 into master will increase coverage by 0.31%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   77.27%   77.59%   +0.31%     
==========================================
  Files          11       11              
  Lines         528      540      +12     
==========================================
+ Hits          408      419      +11     
- Misses        120      121       +1     
Impacted Files Coverage Δ
tobler/tests/test_interpolators.py 97.82% <95.23%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c3f9b2...2a6ddd7. Read the comment docs.

@knaaptime
Copy link
Member

cool, thanks for this. I think is an issue with one of quilt's dependencies not being on conda (you can pip install quilt in a 3.8 env), and its really difficult to tell which.

@sjsrey
Copy link
Member Author

sjsrey commented Jul 12, 2020

The way this is set up (I think) once they do release quilt on conda for 3.8, the tests will get run. Before then only the 3.6 and 3.7 tests will run (which pass).
What I was hoping to do is get a release of Tobler that doesn't block a 3.8 conda install of the meta package, and I think this would do it?

Copy link
Member

@knaaptime knaaptime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@knaaptime knaaptime merged commit 11e4d09 into pysal:master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress, do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants