Simple fix to ValueError issue during CI build #379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this not already fixed by #345 (which is a better approach)? |
|
Yes, #345 fixes my issue. I should have thought to try pip installing the latest master, which indeed works. When you cut a new release I'll go back to installing from PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix based on @EricDeveaud's comment on #349. I was getting the same error when trying to install with
pip install pysamon Travis CI. Now it works fine withpip install https://github.com/standage/pysam.git. Obviously, it would be nice if this got fixed in the next release so we could all go back to using the canonical pip version!