-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Improve calc_measured_loc
performance and support
#57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanded the format of acceptable JRO azimuth and elevation variable names.
Created unit tests for all of the JRO-specific methods.
Added an example for calculating the JRO ISR beam location.
Added a figure showing the results of adding the geographic beam location to JRO ISR data.
Added section labels to the methods documentation.
Updated the examples index to include the JRO ISR beam calculation example.
Updated the changelog to include a new release section, adding the changes made in this branch.
This was
linked to
issues
Sep 14, 2021
aburrell
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
testing
labels
Sep 14, 2021
jklenzing
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Some suggestions below for consistency across projects.
Added `return` to all test methods. Co-authored-by: Jeff Klenzing <jklenzing@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expands the applicability of the
pysatMadrigal.instruments.methods.jro.calc_measured_loc
routine to more az/el variable names, adds an example to the docs, and adds unit tests forpysatMadrigal.instruments.methods.jro
.Partially addresses #3 and #41.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Created an example, which you can follow along in ex_jro_isr_beam.rst to reproduce a figure. Also added unit test to
test_methods_jro.py
.Test Configuration
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release