Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pysb.readthedocs.org is out of date - webhook broken? #215

Closed
alubbock opened this issue Jun 10, 2016 · 2 comments
Closed

pysb.readthedocs.org is out of date - webhook broken? #215

alubbock opened this issue Jun 10, 2016 · 2 comments

Comments

@alubbock
Copy link
Member

I see we have readthedocs webhook intergration set up on github, but it doesn't appear to be updating. The documentation on http://pysb.readthedocs.org at the time of writing is from commit 180bf19, dating from 2015-09-29.

@jmuhlich
Copy link
Member

Ugh, I could have sworn I made sure the build was working when I released v1.1.0. Looks like sphinx-build is failing to read (i.e. execute) doc/conf.py due to this exception:

File "conf.py", line 59, in <module>
  version = pkg_resources.parse_version(release).base_version
AttributeError: 'tuple' object has no attribute 'base_version'

It looks like in setuptools (which provides pkg_resources) before v8.0, pkg_resources.parse_version returned a tuple, but as of v8.0 it returns a custom class (which is what my code in conf.py is expecting). RTD must have a pre-8.0 version installed. I suspect adding the line setuptools>=8 to doc/requirements.txt will fix this. The setuptools major version changes pretty quickly (presumably indicating breaking API changes?) so maybe we should just be explicit and say setuptools>=23,<24 (the current major version).

@jmuhlich
Copy link
Member

A little further explanation: The next commit on master after 180bf19 was when I introduced Versioneer and deleted the get_version function in setup.py, but forgot to update doc/conf.py which was still calling get_version. Then very recently I fixed that issue so at least the docs did build on my local machine, but due to the old setuptools in the RTD default environment it's still broken there.

jmuhlich added a commit to jmuhlich/pysb that referenced this issue Jun 10, 2016
Fixes pysb#215 (default setuptools version in ReadTheDocs too old)
jmuhlich added a commit to jmuhlich/pysb that referenced this issue Jun 10, 2016
Fixes pysb#215 (default setuptools version in ReadTheDocs too old)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants