Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Simulator #sims calculation for NFsim #445

Merged
merged 2 commits into from May 10, 2019
Merged

Fix Simulator #sims calculation for NFsim #445

merged 2 commits into from May 10, 2019

Commits on Apr 26, 2019

  1. Fix Simulator #sims calculation for NFsim 

    Network free simulators use initials_dict instead of initials,
as they don't always have a full list of species available.
The Simulator class calculates the number of simulations by
checking the number of initials and parameter sets defined.
With one parameter set and multiple initials defined, only
one simulation was run (with the first set of initials).

This PR fixes this issue and adds multiple unit tests for NFsim.
    @alubbock
    alubbock committed Apr 26, 2019
    Copy the full SHA
    42c7186 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. Merge branch 'master' into nfsim_fixes

    @alubbock
    alubbock committed May 10, 2019
    Copy the full SHA
    4640070 View commit details
    Browse the repository at this point in the history