Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docstrings Missing #326

Closed
4 of 5 tasks
devendragovil opened this issue Nov 18, 2023 · 1 comment
Closed
4 of 5 tasks

Docstrings Missing #326

devendragovil opened this issue Nov 18, 2023 · 1 comment

Comments

@devendragovil
Copy link
Contributor

devendragovil commented Nov 18, 2023

What

While fixing docstrings, I thought I was not the right person for a few docstrings, so I have added a comment making numpy-doc to skip validation of those functions. This was done so the CI/CD workflow can pass and hence we can move to our usual workflow where PRs are merged only when all GH Actions pass.

How to Detect

There are a total of 5 functions where I have left comments:

# numpydoc ignore=GL08

To Do

These 5 functions need to be resolved.

  • transform.graph_to_simplicial_complex.weighted_graph_to_vietoris_rips_complex.is_in_vr_complex
  • datasets.graph.karate_club
  • datasets.graph.karate_club (another function that is overloaded)
  • datasets.mesh.stanford_bunny
  • datasets.mesh.stanford_bunny (another function that is overloaded)
devendragovil added a commit to devendragovil/TopoNetX that referenced this issue Nov 18, 2023
ffl096 pushed a commit that referenced this issue Nov 19, 2023
… (#325)

* Docstring changes to reduce numpydoc validation issues, helps with #178

* Making changes to docstrings to bring in line with numpydoc recommendations.

Some functions were skipped, see #326

This resolves #178
@ffl096
Copy link
Member

ffl096 commented Nov 28, 2023

Apart from weighted_graph_to_vietoris_rips_complex.is_in_vr_complex, these are overloaded functions that are documented in the "actual" implementation. They do not require a dedicated documentation, as there are only used for type inference.

weighted_graph_to_vietoris_rips_complex.is_in_vr_complex is a little helper function that is not available outside of the scope of weighted_graph_to_vietoris_rips_complex. I don't think we need to document this function either.

@ffl096 ffl096 closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants