Fixed bug where webpage opens on bad paths #878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Calls to
check_all
andcheck_errors
generate an error report when we pass in a path that doesn't exist or is unreadable.Your Changes
Description:
CHANGELOG.md
to document this bug fix.Type of change (select all that apply):
Testing
python
inpyta
repository and calledcheck_all
andcheck_errors
(in reality, they both use the same helper method) with erroneous inputs (both files and directories) and verified that an error message was displayed but no webpage opened. Also tested with different PythonTA reporters.check_all
andcheck_errors
methods with valid inputs and verified this change did not affect the messages being displayed (e.g. removing some by accident).CHANGELOG.md
file to verify it now includes information related to this bug fix.Questions and Comments (if applicable)
ForbiddenPythonSyntaxChecker
hasn't been merged so once it does, there will might be a merge conflict with theCHANGELOG.md
files so that needs to be dealt withChecklist