Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst to recommend pipx run or install #30

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 25, 2024

This pipx approach is recommended in:

Given that fissix runs on Py3.12...
Should nose2pytest run on Python 3.12?
Should nose2pytest run on Python 3.13?

Should the GitHub Actions tests for Python 3.6 and 3.7 be removed?

Can there be a new release to PyPI? https://pypi.org/project/nose2pytest/

This `pipx` approach is recommended in:
* pytest-dev#28
README.rst Outdated

This puts an executable file in ``<python-root>/Scripts`` with *python-root* being the root folder of the
Python installation from which ``pip`` was run.
pipx install --python 3.11 nose2pytest@git+https://github.com/pytest-dev/nose2pytest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I used the install from GitHub was to ensure that the issue I was encountering was not fixed at HEAD. Probably you still want to stick with installing from PyPI and just make sure releases are published there with any updates.

Suggested change
pipx install --python 3.11 nose2pytest@git+https://github.com/pytest-dev/nose2pytest
pipx install --python 3.11 nose2pytest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on #26, should we encourage pipx run instead of pipx install given the transitory nature of using this tool?

Copy link
Contributor Author

@cclauss cclauss Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated for pipx run --python 3.11 nose2pytest path/to/dir/with/python_files.

We will need to ensure there is a new release to PyPI. https://pypi.org/project/nose2pytest/

@cclauss cclauss changed the title Update README.rst to recommend pipx installation Update README.rst to recommend pipx run or install Apr 25, 2024
@cclauss
Copy link
Contributor Author

cclauss commented Apr 29, 2024

@schollii @nicoddemus Your reviews, please.

Copy link
Collaborator

@schollii schollii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cclauss!

The PR mentions a release to pypi, this is as simple as tagging the commit that is mentioned in github release page with "vVER" where is eg 3.10. Do you want to do this for 1.09, 1.10 and 1.11? I'm swamped between work and other projects so that would be hugely appreciated.

@nicoddemus nicoddemus merged commit 2964c29 into pytest-dev:master Apr 29, 2024
18 checks passed
@cclauss cclauss deleted the patch-2 branch April 29, 2024 14:59
This was referenced Apr 30, 2024
@cclauss
Copy link
Contributor Author

cclauss commented Apr 30, 2024

I tried twice to git tag v1.0.9 but was unsuccessful. (My step-by-step notes in #33 and #34).

I will try to work on v1.0.11 later today which should in theory be easier.

@nicoddemus
Copy link
Member

Btw @cclauss the "tag" step is meant to push the tag to pytest-dev/nose2pytest, not a fork -- mentioning just in case that's not clear from the docs.

@cclauss
Copy link
Contributor Author

cclauss commented Apr 30, 2024

Can someone without write permissions push a tag pytest-dev/nose2pytest11? (ChatGPT says No!)

I am not a maintainer of this repo.

@nicoddemus
Copy link
Member

Done: https://github.com/pytest-dev/nose2pytest/releases/tag/v1.0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants