Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated call_historic proc argument #270

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Remove deprecated call_historic proc argument #270

merged 1 commit into from
Jun 7, 2020

Conversation

bluetech
Copy link
Member

@bluetech bluetech commented Jun 5, 2020

Has been deprecated for a while, let's remove it in pluggy 1.0.

Refs #120.

goodboy
goodboy approved these changes Jun 6, 2020
View reviewed changes
Copy link
Contributor

@goodboy goodboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@goodboy
Copy link
Contributor

goodboy commented Jun 7, 2020

@bluetech this one needs a rebase.

@bluetech
Copy link
Member Author

bluetech commented Jun 7, 2020

this one needs a rebase.

Rebased! Now the testing/test_deprecations.py is empty, so I removed it. I wanted to keep it for any future deprecations, but felt funny to have an empty file.

@goodboy goodboy merged commit f3071c7 into pytest-dev:master Jun 7, 2020
@bluetech bluetech deleted the rm-call-historic-proc branch June 28, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodboy goodboy goodboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluetech @goodboy