Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type maker to the library #414

Closed
wants to merge 1 commit into from
Closed

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jul 1, 2023

@@ -3,5 +3,6 @@ include README.rst
include setup.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is good, but given we use setuptools-scm, shouldn't we just drop MANIFEST.in altogether, since setuptools-scm by default will add all git-tracked files to the package by default?

cc @RonnyPfannschmidt

@bluetech
Copy link
Member

bluetech commented Jul 1, 2023

I think the library is not ready for exposing the types yet. It would at least require an audit of types that are (transitively) reachable through the public API, and then documenting and exporting them properly, as they become "official" public API. Something similar to pytest-dev/pytest#7469.

@Tatsh
Copy link

Tatsh commented Jul 8, 2023

I think the library is not ready for exposing the types yet. It would at least require an audit of types that are (transitively) reachable through the public API, and then documenting and exporting them properly, as they become "official" public API. Something similar to pytest-dev/pytest#7469.

I do not understand this position. Without py.typed in this project, @pytest.hookimpl cannot be seen as typed by Mypy. This is not covered by pytest-dev/pytest#7469.

@bluetech
Copy link
Member

bluetech commented Aug 5, 2023

See #428

@bluetech bluetech closed this Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants