Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.17 #248

Closed
asvetlov opened this issue Jan 11, 2022 · 9 comments
Closed

Release 0.17 #248

asvetlov opened this issue Jan 11, 2022 · 9 comments

Comments

@asvetlov
Copy link
Contributor

I think we handled all low-hanging fruits.

I suggest creating a new pytest-asyncio 0.17 release.

Later I want to continue my work on future improvements, but now we have important features implemented.

The release is crucial also as a part of the preparation for working pytest-asyncio and pytest-aiohttp together.
I need a new pytest-asyncio release to raise a warning by pytest-aiohttp if the calculated mode is legacy and rely on pytest-asyncio implementation for auto and strict modes.
Later I'll drop custom async tests and fixtures support from pytest-aiohttp entirely.

@Tinche I can setup auto-deployment on git tag publishing by GitHub actions if you agree with the idea.
For this, I need access to PyPI project for the plugin. My PyPI name is andrew.svetlov

@Tinche
Copy link
Member

Tinche commented Jan 11, 2022

@asvetlov great, thanks so much. I agree with GitHub Actions, and I've invited you to be a co-owner on PyPI.

@seifertm
Copy link
Contributor

Regarding automatic deployments: I just picked up #37 which intended include setuptools_scm to enable automatic deployments based on git tags. Is the PR still relevant for what you intend to do?

@asvetlov
Copy link
Contributor Author

@seifertm great idea!
Declarative setup requires a slightly different configuration placed in pyproject.toml: https://github.com/pypa/setuptools_scm#pyprojecttoml-usage

Otherwise, I completely agree, SCM simplifies the release process a little.

@phlax
Copy link

phlax commented Jan 13, 2022

probably an easyfix but the latest version is throwing an error/warning in some of my tests

INTERNALERROR> DeprecationWarning: The 'asyncio_mode' default value will change to 'strict' in future, please explicitly use 'asyncio_mode=strict' or 'asyncio_mode=auto' in pytest configuration file.

@phlax
Copy link

phlax commented Jan 13, 2022

adding the config to pytest.ini fixed the problem, but im wondering why the default didnt work

nm, ignore me - i have warnings -> errors, so the deprecation warning raised - apologies for noise

@asvetlov
Copy link
Contributor Author

@phlax correct

@asvetlov
Copy link
Contributor Author

pytest-asyncio 0.17 is released

@Tinche
Copy link
Member

Tinche commented Jan 13, 2022

Great job @asvetlov @seifertm !!

@asvetlov
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants