Add mypy as pre-commit hook #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 93.16% // Head: 93.16% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #467 +/- ##
=======================================
Coverage 93.16% 93.16%
=======================================
Files 2 2
Lines 278 278
Branches 56 56
=======================================
Hits 259 259
Misses 12 12
Partials 7 7 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…nment. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
We record coverage for all interpreters and merge them afterwards. There is no longer a need to specify the environment we want to use for measuring coverage. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
seifertm
force-pushed
the
mypy-as-pre-commit-hook
branch
from
c125852 to
19259d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds mypy as a pre-commit hook. As a result, the pipeline can simply run pre-commit and we can get rid of the
make linttarget and thetox -e lintenvironment.This patch also contains a couple of clean-ups to the CI pipeline.