Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code coverage configuration #321

Merged
merged 36 commits into from
Aug 27, 2019
Merged

Refactor code coverage configuration #321

merged 36 commits into from
Aug 27, 2019

Conversation

youtux
Copy link
Contributor

@youtux youtux commented Aug 24, 2019 •
edited
Loading

Changes:

  • tox.ini much more readable
  • always run pytest with coverage (coverage is then combined)
  • switch from Coveralls.io to Codecov, as it is seem to be preferred by the pytest-dev organization, and it seems to be more flexible than Coveralls.
  • Add pytest 5.1.x to the list of pytests to build against

youtux added 30 commits July 4, 2019 16:20
@youtux
Stop testing for old pytest and python versions
bf200a6
@youtux
Switch from pytest-pep8 to pycodestyle.
1ab6c5c 
Pytest-pep8 received the last update in 2014, and it is now not working with pytest >= 4.5
@youtux
Explicitly state used markers
2fcab25
@youtux
Remove supposedly useless test?
e783548 
That test is now breaking in pytest 4.6, and it is a weird one anyway
@youtux
Mark some tags to avoid warning in result
cded225
@youtux
pep8
527efac
@youtux
Fix pytest missing markers definitions
fc98d1c
@youtux
Fix pytest missing markers definitions
b271f14
@youtux
Fix wrong command line usage
06455cf
@youtux
Add missing line at the end of the file
88c94f7
@youtux
WIP attempt to refactor coverage
837df8e 
Still, .coverage is going to contain some test run, not the result of all of them togheter. Also it doesn't always work with `tox -p auto`, because of race conditions
@youtux
Merge branch 'master' into refactor-coverage
2622f6b 
# Conflicts:
#	.travis.yml
#	requirements-testing.txt
#	tox.ini
@youtux
Attempt to do things better
4c667ac
@youtux
try different approach to make sources available to coveralls
731f9e0
@youtux
Try harder
c1a1636
@youtux
trials
a0f8501
@youtux
Merge branch 'master' into refactor-coverage
c8ff140
@youtux
Remove temp
cf71b30
@youtux
Coverage working?
a7c5275
@youtux
Found a configuration that seems to be working for .coveragerc
0d03891
@youtux
New configuration for coverage in CI
b03a74e
@youtux
Add coverage to the configuration, otherwise no coverage will be made
5681573
@youtux
Let Coveralls know that we run parallel builds, and it has to merge o…
e1edb54 
…nly at the end
@youtux
No need for pytest-cov
53048d8
@youtux
Declare that we want coverage in travis env
ed044fa
@youtux
Remove pytest-cache dep
8f8fab6
@youtux
Fix missing dependency
3550100
@youtux
No need to combine coverage? This works?
7099d40
@youtux
Simplify coverage file, no need to specify source
9829411
@youtux
fix missing EOF
8bfc21d
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.398% when pulling 8bfc21d on refactor-coverage into 9a8d608 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.398% when pulling 8bfc21d on refactor-coverage into 9a8d608 on master.

@coveralls
Copy link

coveralls commented Aug 24, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.8%) to 96.898% when pulling 8bfc21d on refactor-coverage into 9a8d608 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.398% when pulling 8bfc21d on refactor-coverage into 9a8d608 on master.

@codecov-io
Copy link

codecov-io commented Aug 24, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@f4dce04). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #321   +/-   ##
=========================================
  Coverage          ?   95.64%           
=========================================
  Files             ?       57           
  Lines             ?     2202           
  Branches          ?      184           
=========================================
  Hits              ?     2106           
  Misses            ?       65           
  Partials          ?       31
Impacted Files Coverage Δ
tests/feature/test_report.py 82.5% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4dce04...a27a0c8. Read the comment docs.

@youtux youtux marked this pull request as ready for review August 24, 2019 11:51
olegpidsadnyi
olegpidsadnyi previously approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@olegpidsadnyi olegpidsadnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

.travis.yml Show resolved Hide resolved
@youtux
Merge branch 'master' into refactor-coverage
a27a0c8 
# Conflicts:
#	pytest.ini
#	requirements-testing.txt
#	tests/feature/test_report.py
#	tox.ini
@youtux youtux merged commit c6b16b6 into master Aug 27, 2019
@youtux youtux deleted the refactor-coverage branch August 27, 2019 16:16
@youtux youtux restored the refactor-coverage branch August 27, 2019 17:07
@youtux youtux deleted the refactor-coverage branch August 27, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegpidsadnyi olegpidsadnyi olegpidsadnyi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youtux @coveralls @codecov-io @olegpidsadnyi